Post #4555197 · Elektrine

2026-08-28 05:52 UTC

I just realized I have hard time formulating in a brief and systematic way what exactly do I check during a code review. I had a similar issue when I had to setup a checklist for the interview processes... With my abstract mind all runs on "it doesn't fit". If I try to make a checklist, it becomes and excessive crap that even I don't follow. Doesn't click well when you try to share it with others... Do you have any similar experiences and how do you manage? #adhd #softwareengineering

Replies (1)

@bradr@infosec.exchange 2026-08-28 07:34

@djumaka@phpc.social what exactly do I check during a code review Ideas: If you're doing this in a business context, we find it helps to reframe this from "What do I check?" to "What must I cause?". Make it a discovery conversation, a don't-know-you-don't know conversation, a breadth-first conversation. For anything complicated, save negotiating solutions and fixes for a separate convo. Avoid rat-holes. It helps to drive it systematically by considering required questions to ask, which can vary depending on what the code is for. But a common list is something like: What problem is the unit/patch built to solve? What does it leave undone?What (in the design or implementation) creates risks to safety/security/privacy?What creates risks to maintainability? Does it introduce new dependencies sensibly?Does it conform to applicable specs/standards/regs?Where does it misunderstand/abuse its interfaces?Who needs to review this to adequately cover these questions? Who isn't here?

Open ##4555195